Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(settings): Remove usage of jQuery #3201

Merged
merged 1 commit into from
Sep 11, 2024
Merged

refactor(settings): Remove usage of jQuery #3201

merged 1 commit into from
Sep 11, 2024

Conversation

provokateurin
Copy link
Member

No description provided.

@provokateurin provokateurin added 3. to review Items that need to be reviewed technical debt labels Sep 10, 2024
Base automatically changed from refactor/settings/promise to master September 10, 2024 16:04
@provokateurin provokateurin marked this pull request as ready for review September 10, 2024 16:04
artonge
artonge approved these changes Sep 11, 2024
View reviewed changes
src/settings/Api.ts Show resolved Hide resolved
@provokateurin
Copy link
Member Author

provokateurin commented Sep 11, 2024 •
edited
Loading

Cypress failure is due to nextcloud/server#47848 (comment). @artonge can you merge or is it too risky to skip cypress?

susnux
susnux approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring, some comments but not about your code 😅

src/settings/Api.ts Outdated Show resolved Hide resolved
src/settings/Api.ts Outdated Show resolved Hide resolved
src/settings/Api.ts Outdated Show resolved Hide resolved
@provokateurin provokateurin mentioned this pull request Sep 11, 2024
Merged
@provokateurin provokateurin merged commit 0358d12 into master Sep 11, 2024
45 checks passed
@provokateurin provokateurin deleted the refactor/settings/remove-jquery branch September 11, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@provokateurin @susnux @artonge